-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle %spot
and %mean
hints to produce stack traces
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashelkovnykov
force-pushed
the
as/trace
branch
2 times, most recently
from
June 27, 2023 23:11
c163400
to
c513bda
Compare
ashelkovnykov
force-pushed
the
as/trace
branch
3 times, most recently
from
August 24, 2023 15:57
2b07d91
to
6b98099
Compare
ashelkovnykov
force-pushed
the
as/trace
branch
2 times, most recently
from
September 5, 2023 18:47
c453c13
to
fd95ade
Compare
ashelkovnykov
changed the title
WIP: handle %spot hints to produce stack traces
Handle Sep 16, 2023
%spot
and %mean
hints to produce stack traces
ashelkovnykov
force-pushed
the
as/trace
branch
from
September 19, 2023 22:15
344ff6f
to
d122f1d
Compare
eamsden
reviewed
Sep 28, 2023
eamsden
requested changes
Sep 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mean stack slot allocation should be done by passing 1 more to frame_push() in interpreter::push_formula, not by altering the format of frames generally.
eamsden
requested changes
Oct 4, 2023
eamsden
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables stack traces to be printed on error and at will (using the
%hela
hint).Summary:
hoon.hoon
environment+cap
+mas
+rap
+lent
+mink
+scow
%spot
%mean
%hela
%slog
hint handling