site: call site caching #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we failed to record node partitions in the flist on restore. No we do so
…itions-in-flist-on-restore pma: fix memory corruption restoration bug
Link to `DEVELOPERS.md` for alpha release
Update DEVELOPERS.md with more detail
fix two weird bugs
joemfb
reviewed
Jun 14, 2024
|
Indeed, I will once I ensure it works correctly.
…On Fri, Jun 14, 2024 at 6:44 PM Joe Bryan ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In rust/ares/src/jets/hot.rs
<#242 (comment)>:
> @@ -219,6 +224,11 @@ pub const URBIT_HOT_STATE: &[HotEntry] = &[
1,
jet_jam,
),
+ (
+ &[K_139, Left(b"one"), Left(b"two"), Left(b"by"), Left(b"rep")],
+ 1,
+ jet_by_rep,
+ ),
Note: you can declare this same jet as +rep:in, the signatures are
completely compatible.
—
Reply to this email directly, view it on GitHub
<#242 (review)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AV2DQRC5QPX7IYZ3ABS5NN3ZHNW5FAVCNFSM6AAAAABJKZSJPKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMJZGQ2DOMRRHA>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
|
#243 should be investigated along with these changes. |
|
Closed because I added the operative code to #245. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a very barebones call site caching module, and uses it for these jets:
+turn(updated implementation)+roll(new jet)+rep:by(new jet)+rep:in(new jet; same as+rep:by)Checkmarks denote successful testing on
macos-aarch64.Note that one of the big open PRs right now (I believe a codegen one) includes map/set jets in the
seammodule, but I called my map jetsmaps. Happy to reconcile later and add mine toseam, but not worth the git cherrypicking right now.