integrate urcrypt jets #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashelkovnykov
suggested changes
Nov 22, 2023
There was a problem hiding this comment.
Most of the comments are regarding punting and stripping trailing 0s from input. Two questions:
- Why does Vere punt on invalid key length? Does it not result in an error? If it does, shouldn't we just bail in the jet?
- When do we need to strip trailing
0s and when do we not need to do so?
ashelkovnykov
approved these changes
Nov 25, 2023
This was referenced Nov 25, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges and updates #90 cc @matthew-levan
should be merged after the
as/demo-debugbranch and #122 cc @ashelkovnykovdepends on urbit/urcrypt-sys#1