Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify additional RTD build options #213

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

dataflake
Copy link
Member

This adds support for additional lines to be inserted into the .readthedocs.yaml build configuration section. This is useful to e.g. install additional packages in the OS.

@dataflake dataflake requested a review from icemac October 5, 2023 06:58
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but where is it needed?

@dataflake
Copy link
Member Author

This is needed for things like database adapters that must have database libraries or databases installed on the test server. I use it for Products.LDAPUserFolder right now, but it will also be needed when updating Products.ZpsycoPGDA and Products.ZMySQLDA

@dataflake dataflake merged commit aab35d7 into master Oct 6, 2023
4 checks passed
@dataflake dataflake deleted the rtd_build_extra branch October 6, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants