Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#112 Add windows to github actions #208

Merged
merged 11 commits into from
Mar 28, 2024
Merged

Conversation

vernans
Copy link
Contributor

@vernans vernans commented Sep 22, 2023

Closes #112

It's not pretty but the built wheels seem to work.

Persistent and ExtensionClass were tested

zopefoundation/ExtensionClass#72

zopefoundation/persistent#190

When updating the repositories, with_appveyor needs to be set to false, also I'd set with_windows to true even though it is not used in c-code packages at the moment.

@vernans vernans requested a review from icemac September 22, 2023 14:15
@dataflake
Copy link
Member

I have made one change: Instead of always selecting the Windows runners I want the with_windows flag to govern that. So setting with_windows has a meaning. A quick manual test shows me that it does the right thing.

@dataflake
Copy link
Member

@icemac I like this idea a lot. If the process of creating wheels and automatically uploading them to PyPI when a tag is encountered works as before then this is much better than Appveyor.

After updating the 13(!) binary packages Zope depends on yesterday my choice is for moving everything to GitHub. For some packages it took more than two hours for the Windows wheels to appear on PyPI. Appveyor behavior and speed was very erratic. The queue seemed to hang forever on some of the projects.

@icemac
Copy link
Member

icemac commented Mar 25, 2024

@vernans @dataflake I additionally completely removed appveyor and added support for Python 3.13 on Windows, see zopefoundation/ExtensionClass#72 and zopefoundation/persistent#190 as examples.

Please (re-)review.

@icemac icemac merged commit 1404d28 into master Mar 28, 2024
4 checks passed
@icemac icemac deleted the add-windows-to-github-actions branch March 28, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Build Windows wheels on GHA
3 participants