Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the meta repository to compute the branch. #202

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Conversation

icemac
Copy link
Member

@icemac icemac commented Aug 23, 2023

No description provided.

@icemac icemac added the bug Something isn't working label Aug 23, 2023
@icemac icemac self-assigned this Aug 23, 2023
@icemac icemac requested a review from dataflake August 23, 2023 08:02
Copy link
Member

@dataflake dataflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no comment, but I am guessing this is just to make extra sure the meta repository commit id is used for cases where someone runs the script outside of the meta clone, so that's fine.

@icemac
Copy link
Member Author

icemac commented Aug 28, 2023

Previously the git commit hash of the package to be configured was used now it is using the commit hash of the meta repository.

Thank you for reviewing this PR. 😃

@icemac icemac merged commit 91a2658 into master Aug 28, 2023
4 checks passed
@icemac icemac deleted the fix-branch-name branch August 28, 2023 12:44
gforcada pushed a commit to plone/meta that referenced this pull request Sep 16, 2023
Based on zopefoundation/meta#202

The main benefit here is that when pushing updates on multiple
repositories the branches are all the same, making it easier to
see that they are based on the same changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants