mini-feat(docs) Troubleshooting: Added a note on the experimental bluetooth connection options #2387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would fix #2170. |
caksoylar
reviewed
Jul 22, 2024
|
Adjusted as per Discord conversation. |
caksoylar
reviewed
Jul 22, 2024
There was a problem hiding this comment.
LGTM, thanks!
Can I also ask you to move "Issues With Dual Boot Setups" under this header? It's technically an "unable to connect" issue.
Also a note (for this PR or a future one): The description of CONFIG_ZMK_BLE_EXPERIMENTAL_CONN should be updated since it only includes the 2M change right now (after Zephyr 3.5 upgrade), AFAIK.
caksoylar
reviewed
Jul 22, 2024
Co-authored-by: Cem Aksoylar <[email protected]>
|
Requested changes have been made. |
flolbr
pushed a commit
to flolbr/zmk
that referenced
this pull request
Jul 28, 2024
…ns (zmkfirmware#2387) Co-authored-by: Cem Aksoylar <[email protected]>
Nick-Munnich
added a commit
to Nick-Munnich/zmk
that referenced
this pull request
Aug 3, 2024
…ns (zmkfirmware#2387) Co-authored-by: Cem Aksoylar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under the connection-issues subsection of troubleshooting there is now a new section and a few sentences.