Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(boards): Suppress spurious devicetree warning for nRF5x boards #2318

Merged
merged 2 commits into from
Jun 30, 2024

Conversation

ReFil
Copy link
Contributor

@ReFil ReFil commented May 31, 2024

nRF5x boards throw a spurious warning for duplicate unit-address when the devicetree gets processed

Upstream issue: zephyrproject-rtos/zephyr#29713

Warning suppressed as per: https://docs.zephyrproject.org/latest/build/dts/intro-input-output.html

Tested on a few nRF5x boards and i have no reason to think it would break things on the untested ones

@ReFil
Copy link
Contributor Author

ReFil commented May 31, 2024

Looking at the results of the CI it seems that the pre_dt_board.cmake file needs to be placed here:https://github.com/zmkfirmware/zephyr/tree/v3.5.0%2Bzmk-fixes/boards/arm/seeeduino_xiao_ble for the seeduino xiao BLE

nRF5x boards throw a spurious warning for duplicate unit-address when the devicetree gets processed

Upstream issue:  zephyrproject-rtos/zephyr#29713

Warning suppressed as per: https://docs.zephyrproject.org/latest/build/dts/intro-input-output.html

Tested on a few nRF5x boards and i have no reason to think it would break things on the untested ones
@ReFil ReFil changed the title fix(boards): Suppress spurious devicetree warning for nRF5x boardss fix(boards): Suppress spurious devicetree warning for nRF5x boards May 31, 2024
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Will need to fix the seeeduino XIAO BLE upstream and cherry pick in, to address that one. Good to fix these for now though to have good in tree reference boards.

@petejohanson petejohanson merged commit f2ea1da into zmkfirmware:main Jun 30, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants