Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): Modify function return type to remove compiler warning #2229

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

huber-th
Copy link
Contributor

@huber-th huber-th commented Mar 27, 2024

Function sticky_key_timeout is defined with return type int, yet it is not returning any value. Both calls to this function also ignore the return value. Therefore the return type is modified to void to remove this warning.

Change return type of `sticky_key_timeout` function to `void` given it
does not return any value to remove compiler warnings.
@huber-th huber-th requested a review from a team as a code owner March 27, 2024 21:30
@huber-th huber-th changed the title Modify function return type to remove compiler warning; Add clangd cache to .gitignore Modify function return type to remove compiler warning Mar 27, 2024
@huber-th huber-th changed the title Modify function return type to remove compiler warning fix(build) Modify function return type to remove compiler warning Mar 27, 2024
@huber-th huber-th changed the title fix(build) Modify function return type to remove compiler warning fix(build): Modify function return type to remove compiler warning Mar 27, 2024
@petejohanson petejohanson added bug Something isn't working behaviors labels Mar 27, 2024
@petejohanson petejohanson self-assigned this Mar 27, 2024
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will merge once tests finish.

@petejohanson petejohanson merged commit 58ccc59 into zmkfirmware:main Mar 27, 2024
45 checks passed
@huber-th huber-th deleted the fix-compile-warning branch March 28, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behaviors bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants