feat(build): Allow specifying snippets for a build. #2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelspadin
reviewed
Mar 24, 2024
There was a problem hiding this comment.
This is a bit inconsistent with how we pass shields. It seems weird to me that you would need to write
- board: nice_nano_v2
shield: corne_left nice_view_adapter nice_viewto use multiple shields, but
- board: nice_nano_v2
snippets: [snippet1, snippet2, snippet3]to use multiple snippets
| @@ -59,12 +59,16 @@ jobs: | |||
| run: | | |||
| echo "build_dir=$(mktemp -d)" >> $GITHUB_ENV | |||
|
|
|||
| - name: Install yaml2json | |||
| run: apt-get update && apt-get install -y jq python3-pip && python3 -m pip install remarshal | |||
There was a problem hiding this comment.
This doesn't match the step with the same name on line 38. Should those match?
Also, would https://github.com/actions/setup-python be better for making sure pip is installed?
* Allow using snippets https://docs.zephyrproject.org/latest/build/snippets/using.html for user builds in a `snippets` array properly.
petejohanson
force-pushed
the
user-build-snippets
branch
from
e419c60
to
4b8e83a
Compare
|
After some discussion and discovery, simplified things a ton, and here's a successful build with the new simpler approach: https://github.com/petejohanson/le-capybara-zmk-config/actions/runs/8413180471/job/23035032995 |
joelspadin
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
snippetsarray propertly.You can see this in action in https://github.com/petejohanson/le-capybara-zmk-config/actions/runs/8412145898 which enables an extra EC calibration utility using a snippet there.