Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Refactor Part 1 #2086

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

xudongzheng
Copy link
Contributor

@xudongzheng xudongzheng commented Dec 30, 2023

The motivation for this PR is to be the first part of #2080. The commits should be pretty self-contained and easy to review.

The split run and indicator I haven't refactored yet since that will require some larger changes related to how multiple peripherals are handled. That will likely be part of a separate PR later.

@xudongzheng xudongzheng requested a review from a team as a code owner December 30, 2023 05:30
@xudongzheng xudongzheng force-pushed the split-refactor1-pr branch 4 times, most recently from ded3c1c to 96c028f Compare December 30, 2023 17:52
@xudongzheng xudongzheng force-pushed the split-refactor1-pr branch 2 times, most recently from a52ce6a to 30ff612 Compare January 15, 2024 03:36
@spiicy-sauce
Copy link

@xudongzheng any update on this? I was looking to build a wired-split board and I'd love to try this out if it's stable enough to play with.

@xudongzheng
Copy link
Contributor Author

@xudongzheng any update on this? I was looking to build a wired-split board and I'd love to try this out if it's stable enough to play with.

This PR is the refactoring portion and will likely be reviewed separately from the actual split serial PR #2080.

That PR has a new commit f28e8fc with code for sending key press data from peripheral to central. Functionally that's was the main missing part for testing on an actual keyboard. It should work in theory though I've only tested with my development board. That PR as a whole should still be considered experimental and is still missing some stuff.

@spiicy-sauce
Copy link

Cool, thanks for the update. I'll check that out.

@sontags
Copy link

sontags commented Aug 22, 2024

Hi @xudongzheng. Thanks for your work on this topic! Is there any progress to be expected on the "wired split" front? Would a sponsorship help?

@xudongzheng
Copy link
Contributor Author

xudongzheng commented Aug 22, 2024

Hi @xudongzheng. Thanks for your work on this topic! Is there any progress to be expected on the "wired split" front? Would a sponsorship help?

@sontags The complete PR in #2080 is largely functional. To my knowledge, there are quite a few people running it successfully, and you can find several relevant discussions on Discord.

The refactoring part of that PR is split into this PR for ease of review. The main PR will be cleaned up and taken out of "draft" status after this PR is resolved.

@Nick-Munnich Nick-Munnich added core Core functionality/behavior of ZMK split bluetooth Bluetooth related items refactor labels Aug 22, 2024
@xudongzheng xudongzheng requested a review from a team as a code owner August 29, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bluetooth Bluetooth related items core Core functionality/behavior of ZMK refactor split
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants