Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Underglow): Battery state of charge effect #1456

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ReFil
Copy link
Contributor

@ReFil ReFil commented Sep 13, 2022

This adds a state of charge effect to RGB underglow. Potentially a duplicate of #935 however this is significantly different

  • I use the battery library to get state of charge instead of the Bluetooth BAS function to handle applications where BAS was disabled
  • Using HSB instead of RGB and inheriting from the state.colour allows the previously set or default brightness to be used in calculating the colour, this has to temporarily override the saturation to show the colours properly though
  • Uses the new battery chosen node binding and like the other PR displays blue when no battery is configured. to avoid any ambiguity
  • Added the effect to KConfig

@ReFil
Copy link
Contributor Author

ReFil commented Feb 12, 2024

Rebased and tweaked to add a void arg to the effect function in line with the other rgb effects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant