Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(battery): prevent bus fault when battery does not exist
zmk_battery_start_reporting() may be called from battery_event_listener(), which will result in a bus fault when attempting to read a battery that does not exist such as on a dongle.
- Loading branch information
6bf4870
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit is causing my board to intermittently freeze at start up.
I used this command to build my firmware:
After copying the firmware to the board, it either hang immediately on the automatic reboot, or would hang a couple seconds after a reset. Reboot to bootloader still work.
The board does has battery attached. But have tried disconnecting battery and it still hang.
After reverting this commit and build again, the firmware works perfectly.