Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following upon #461, updating the go version to latest, the 1.23 release gives us many new improvements in both the compiler land and tooling land to utilize:
min, max
, so we don't have to constantly implement our own, see:utility.go:129
,modules/mssql/connection.go:749
,modules/oracle/types_test.go:455
,lib/ssh/channel.go:134
How to Test
CI/CD involved should handle it. As Go team noted in all release notes since 1.20 (current version in this project) to now,
Compiling and running the program yields no issues.
Notes & Caveats
Only one "breaking" compile-time issue found in
modules/amqp091/scanner.go:250
, whereChannelMax
was expecting anint
but got anuint16
. Casting here is safe as this is a type promotion with no requirements for this variable to be exactly 16 bits.Issue Tracking
Add a link to the relevant GitHub issue(s) if the pull request resolves it.