Update ZkBobPay contract #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akolotov
reviewed
Aug 14, 2023
| } | ||
|
|
||
| (bool status,) = oneInchRouter.call{value: msg.value}(_oneInchData); | ||
| (bool status,) = _router.call{value: msg.value}(_routerData); |
There was a problem hiding this comment.
in order to increase security does it make sense to keep of list of allowed methods for the particular router?
There was a problem hiding this comment.
Sure, not sure if it would make much sense in case of 1inch, since it will require supporting almost all selectors. But for li.fi this sounds reasonable. It looks like we only need to support one selector for swapTokensGeneric(...) - https://louper.dev/diamond/0x1231DEB6f5749EF6cE6943a275A1D3E7486F4EaE?network=polygon
Implemented in 85f55a9
k1rill-fedoseev
force-pushed
the
feat/payment-link-updates
branch
from
7eaa4e8
to
85f55a9
Compare
akolotov
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog