WIP: Use fetchSize, return next page instead of the current one #2592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2591
Problem
The above query would only fetch 5000 pages regardless of value of
fetchSize
provided.That's because of 2 reasons:
Solution
Take the fetchSize into account
Return the next page instead of the current one
Unit test all changes
Update
README.md
if applicableAdd
[WIP]
to the pull request title if it's work in progressSquash commits that aren't meaningful changes
Run
sbt scalariformFormat test:scalariformFormat
to make sure that the source files are formatted@getquill/maintainers