Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify AssociativeFlattenCovariantOps#flatMap code #1417

Open
wants to merge 1 commit into
base: series/2.x
Choose a base branch
from
Open

Simplify AssociativeFlattenCovariantOps#flatMap code #1417

wants to merge 1 commit into from

Conversation

guizmaii
Copy link
Member

No description provided.

@guizmaii guizmaii requested a review from a team as a code owner November 14, 2024 02:52
@guizmaii guizmaii self-assigned this Nov 14, 2024
sideeffffect
sideeffffect approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@sideeffffect sideeffffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we're in the definition of an extension method. Here, isn't it better to use bare instances and there methods (instead of other extension methods)?

But if you feel strongly about it, feel free to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideeffffect sideeffffect sideeffffect approved these changes

Assignees

@guizmaii guizmaii

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guizmaii @sideeffffect