Test non-default branches in sandbox #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudw
requested review from
talebzeghmi,
akdigitalself,
aaron-arellano and
cavandervoort
|
I believe that this MR is not necessary yet benign because these test flows do not affect the health of the cluster because they are simply flows that run and do not modify the cluster, and hence could run in NonProd. Because it is benign, I think it's OK to move to MR runs in sandbox, until or unless they are blocking. |
aaron-arellano
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in tech review session 8/29, non feature branches should be tested in sandbox. Only stable changes from the default branches are allowed in the internal cluster.