Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping the minor version to 2.3 #308

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Bumping the minor version to 2.3 #308

merged 1 commit into from
Aug 23, 2024

Conversation

cloudw
Copy link
Collaborator

@cloudw cloudw commented Aug 22, 2024

ArgoHelper is quite some change comparing to the previous version, despite no customer adoption previously. Bumping the minor version to make this distinction. Also, we can track MRs released between now and metaflow zg-2.2 easily.

@cloudw cloudw self-assigned this Aug 22, 2024
@cavandervoort
Copy link

ArgoHelper is quite some change comparing to the previous version, despite no customer adoption previously. Bumping the minor version to make this distinction. Also, we can track MRs released between now and metaflow zg-2.2 easily.

This makes sense to me.

Would it have made more sense to bump the minor version in the PR that added ArgoHelper? Even if yes, it's too late now, and I support having a new minor version to make it easier to know which projects can and can't use ArgoHelper.

Copy link

@cavandervoort cavandervoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there was another PR that was about to get merged, I'd prefer this change to happen there. But none of the open PRs seemed very close to being merged, so I think this makes sense.

@cloudw cloudw merged commit 7942609 into feature/aip Aug 23, 2024
4 checks passed
@cloudw cloudw deleted the yunw/2.3-release branch August 23, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants