Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor][bugfix] Remove redundant generateName #305

Merged
merged 1 commit into from
Aug 20, 2024
Merged

[minor][bugfix] Remove redundant generateName #305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions metaflow/plugins/aip/aip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,10 +291,9 @@ def _create_workflow_yaml(
# Note the name has to follow k8s format.
# self.name is typically CamelCase as it's python class name.
# generateName contains a sanitized version of self.name from aip.compiler
default_workflow_name = workflow["metadata"].pop("generateName").rstrip("-")
workflow["metadata"]["name"] = (
sanitize_k8s_name(name)
if name
else workflow["metadata"].pop("generateName").rstrip("-")
sanitize_k8s_name(name) if name else default_workflow_name
)

# Service account is added through webhooks.
Expand Down
Loading