AIP-7418 Remove KFP cluster create #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlatchford
approved these changes
Oct 10, 2023
cloudw
approved these changes
Oct 11, 2023
* AIP-7385 rename KFP to AIP plugin * friendly error message for "kfp run" * AIP-7393 Add Flow labels to Workflow for ArgoUI (#259) * AIP-7393 Add Flow labels to Workflow for ArgoUI * PR feedback * AIP-7726 add default cards (#260) * AIP-7726 add default cards * param fix * PR feedback - comment archive none - add card id to support current.card.append() - add example of notebook card & multiple cards * aip.zillowgroup.net/aip-pod-default -> aip.zillowgroup.net/aip-wfsdk-pod * logging.zgtools.net/index -> logging.zgtools.net/topic * fix card pathspec for nested foreach * fix github test.yml branches * resources_flow.py label fixes * PR Feedback * update test.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the ability for WFSDK to create sticky long term k8s resources in the k8s cluster such as the WorkflowTemplate and CronWorkflow.
The reason for this is that k8s garbage collection and pruning policy becomes much more difficult to manage than Gitlab projects that have environments, and PRs that get merged with attached cleanup jobs and corresponding pruning steps by label.
TODO
createcommand