AIP-8595 truncate volume name

zillow · Sep 14, 2024 · 0ac13aa · 0ac13aa
1 parent 9280783
commit 0ac13aa
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/metaflow/plugins/aip/aip.py b/metaflow/plugins/aip/aip.py
@@ -957,7 +957,9 @@ def _create_volume(
         size: str,
         volume_type: Optional[str],
     ) -> Tuple[ResourceOp, PipelineVolume]:
-        volume_name = "{{pod.name}}"
+        # AIP-8595(talebz): to avoid volume name "must be no more than 63 characters error"
+        # truncate from the beginning (the suffix has more entropy)
+        volume_name = "{{=sprig.trunc(-63, pod.name)}}"
         attribute_outputs = {"size": "{.status.capacity.storage}"}
         requested_resources = V1ResourceRequirements(requests={"storage": size})
 

diff --git a/metaflow/plugins/aip/tests/flows/resources_flow.py b/metaflow/plugins/aip/tests/flows/resources_flow.py
@@ -125,7 +125,8 @@ def __repr__(self):
         return "Dataset"
 
 
-class ResourcesFlow(FlowSpec):
+# AIP-8595(talebz): To validate that volume names are truncated to 63 characters
+class ResourcesFlowLooooooooooooooooooooooongNaaaaaaaaaaaaaaaaaaaaame(FlowSpec):
     json_param: Dict = Parameter(
         "json_param", default=default_dict, type=TestTypeClass()
     )
@@ -216,4 +217,4 @@ def end(self):
 
 
 if __name__ == "__main__":
-    ResourcesFlow()
+    ResourcesFlowLooooooooooooooooooooooongNaaaaaaaaaaaaaaaaaaaaame()