Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update weaviate installation to check for weaviate pkg instead of… #560

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

amrit2cisco
Copy link

weaviate-client won't be found by importlib.util.find_spec, should be searching for weaviate to check dependency installation instead

Signed-off-by: Amrit Singh [email protected]

…aviate-client

weaviate-client won't be found by importlib.util.find_spec, should be searching for weaviate to check dependency installation instead

Signed-off-by: Amrit Singh <[email protected]>
@sre-ci-robot sre-ci-robot requested review from cxie and SimFG October 27, 2023 16:13
@amrit2cisco
Copy link
Author

/assign @cxie

Update unit test

Signed-off-by: Amrit Singh <[email protected]>
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amrit2cisco
To complete the pull request process, please ask for approval from cxie after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Amrit Singh <[email protected]>
@SimFG SimFG assigned SimFG and unassigned cxie Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants