macho: set minimum default headerpad to 32 bytes #20481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches Apple's ld and LLVM's lld.
what happens if we don't? |
|
One example I know is that LLVM TSAN dylib is malformed. But it is arguably an invalid assumption by LLVM. Having said that if all linkers in the wild assume a nonzero padding for images, who knows what else can break in the wild, and worse some tooling by Apple. |
|
did you mean to disable auto-merge? |
I did. Jacob suggested checking if we can further fault LLVM's TSAN which would result in a very clear bug report upstream. |
|
@nektro upstream issue: llvm/llvm-project#97627 It was indeed possible to fault TSAN with LLVM's linker. |
|
In the light of the above, I am closing this PR as it is worse than the hackiest hack to make another hack work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches Apple's ld and LLVM's lld.