[std.fmt] Added parsing support for f80 #20462
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiehuis
reviewed
Jul 1, 2024
There was a problem hiding this comment.
Looks pretty good.
Can you remove this (no longer needed) check here for float round-tripping? then I will trigger the CI:
zig/lib/std/fmt/format_float.zig
Line 1524 in cb308ba
| .max_exponent_fast_path_disguised = 46, | ||
| .max_mantissa_fast_path = 2 << std.math.floatMantissaBits(T), | ||
| // Slow + Eisel-Lemire | ||
| .mantissa_explicit_bits = std.math.floatFractionalBits(T), |
There was a problem hiding this comment.
I think it is clearer if we change the other float types to use floatFractionalBits instead of floatMantissaBits as done here. The value is the same for the other IEEE types.
tiehuis
reviewed
Jul 2, 2024
| @@ -72,8 +77,6 @@ pub fn isEightDigits(v: u64) bool { | |||
| } | |||
|
|
|||
| pub fn isDigit(c: u8, comptime base: u8) bool { | |||
| std.debug.assert(base == 10 or base == 16); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #19263
Test plan:
zig test lib/std/fmt/parse_float.zigpasses locally with additional f80 unit tests