std.Build.option: Improve type detection logic #20435
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikskuh
reviewed
Jul 3, 2024
Comment on lines
+1544
to
+1546
| const complex_type: ?TypeId = switch (@typeInfo(T)) { | ||
| .Int => .int, | ||
| .Float => .float, |
There was a problem hiding this comment.
Can you also add the comptime variants here? Tihs would allow using .{ .foo = 10 }
There was a problem hiding this comment.
This requires turning those values into strings, as they would be if they were passed through command line arguments; I made it into a separate PR since the code that needs to be changed is in another function: #20499
… unsupported types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the type detection logic of
optionto more accurately raise errors for all invalid types.Currently, passing any pointer-to-u8 or pointer-to-enum type other than
[]const u8or[]const AnEnumraises unhelpful compile errors elsewhere in the code.(split from original #20412)