[WIP] Guzzle 5 #14
Open
[WIP] Guzzle 5 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -193,7 +193,7 @@ | |||
| * @method ResourceIterator getBalanceTransactionsIterator() | |||
| * @method ResourceIterator getEventsIterator() | |||
| */ | |||
| class StripeClient extends Client | |||
| final class StripeClient | |||
There was a problem hiding this comment.
Don't make a class final unless you have an implemented interface for it (makes mocking and composition impossible)
|
I'm closing for now. Guzzle Services has finally been tagged to 1.0.0 which in turn updates Guzzle to version 6. It has quite a bit of change and this PR is not really ocmpatibel anymore. If anyone would like to tackle an upgrade, I've already upgraded anther package of mine that could service as a reference: https://github.com/zf-fr/zfr-shopify |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.