Token request attribute configurable #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On PHP 7.1: There was 1 failure:
|
prolic
reviewed
Mar 10, 2017
| * @param ResourceServerInterface $resourceServer | ||
| */ | ||
| public function __construct(ResourceServerInterface $resourceServer) | ||
| public function __construct(ResourceServerInterface $resourceServer, ServerOptions $serverOptions) |
There was a problem hiding this comment.
Maybe allow null for server options and use default then?
There was a problem hiding this comment.
yeah, I saw too this but didn't want to change it all over the place again.
But if I do I think it is be better to simply pass the option itself, unless there are more then 3 or 4 constructor arguments or the instance needs to pass them on to other dependencies. What do you think?
basz
force-pushed
the
token-request-attribute-configurable
branch
from
3abf61d
to
bbbe022
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.