Extend platform support for WSI without the need to include windowing API #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…creen QNX. As was already present for Win32. Added guards to prevent redefintion of window api constructs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment volk allows the user to use WSI functions for the Win32 platform without having to include
windows.h.This is a very useful feature not only to prevent unwanted definitions and reduce compile time but it also allows the developer to separate code handling windowing from the code that handles rendering.
Unfortunately this is not currently available on any other platform.
I have identified the platforms that could benefit from this feature and added it on my fork.
In addition to that I added guards that prevent redefinition of types in case the user includes the library (not that they must be included before
volk.hfor this to work).I think this is a good change to take into the master branch.