CMake: Fix include path discovery when using FindVulkan.cmake #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volk does not need libvulkan.so dependency, and in fact adding it is dangerous due to possible symbol conflicts and unnecessary as the point of using volk is to avoid direct dependencies on Vulkan loader. When FindVulkan.cmake discovered a Vulkan installation, it would erroneously depend on Vulkan::Vulkan which would add libvulkan.so dependency. Instead, rework all of this to just get the include path from the module or compute it from other variables. This setup is cleaner and it guarantees that we aren't going to get any rogue flags into the build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
volk does not need libvulkan.so dependency, and in fact adding it is dangerous due to possible symbol conflicts and unnecessary as the point of using volk is to avoid direct dependencies on Vulkan loader.
When FindVulkan.cmake discovered a Vulkan installation, it would erroneously depend on Vulkan::Vulkan which would add libvulkan.so dependency.
Instead, rework all of this to just get the include path from the module or compute it from other variables. This setup is cleaner and it guarantees that we aren't going to get any rogue flags into the build.
Fixes #134.