Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: erc20 auth calls #3012

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

feat: erc20 auth calls #3012

wants to merge 3 commits into from

Conversation

skosito
Copy link
Contributor

@skosito skosito commented Oct 16, 2024

Description

in progress, missing e2e tests

in sync with: zeta-chain/protocol-contracts#401

How Has This Been Tested?

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

@skosito skosito added the V2_TESTS Run make start-v2-test label Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 66.25%. Comparing base (250b90e) to head (1e162cf).

Files with missing lines Patch % Lines
pkg/contracts/testdappv2/TestDAppV2.go 0.00% 12 Missing ⚠️
zetaclient/chains/evm/signer/v2_sign.go 0.00% 11 Missing ⚠️
zetaclient/chains/evm/signer/v2_signer.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3012      +/-   ##
===========================================
- Coverage    66.25%   66.25%   -0.01%     
===========================================
  Files          406      406              
  Lines        22772    22773       +1     
===========================================
  Hits         15088    15088              
- Misses        6907     6908       +1     
  Partials       777      777              
Files with missing lines Coverage Δ
zetaclient/chains/evm/signer/v2_signer.go 0.00% <0.00%> (ø)
zetaclient/chains/evm/signer/v2_sign.go 0.00% <0.00%> (ø)
pkg/contracts/testdappv2/TestDAppV2.go 0.00% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2_TESTS Run make start-v2-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant