Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

675 documentation #714

Merged
merged 3 commits into from
Mar 19, 2024
Merged

675 documentation #714

merged 3 commits into from
Mar 19, 2024

Conversation

zerothi
Copy link
Owner

@zerothi zerothi commented Mar 15, 2024

First attempt at doing something for the documentation.

This is far from complete, but some feedback on how it looks might be valuable.

It seems notebooks are just simpler to use, and perhaps we should just stick with that :)

You can see the page here:
https://www.student.dtu.dk/~nicpa/sisl/html/rtd/index.html

I would like to hide a bit more in the menu to the left, or at least move up the guides/tutorials etc.
Easy to do things.

  • Closes Documentation rework #675
  • Added tests for new/changed functions?
  • Ran isort . and black . [24.2.0] at top-level
  • Documentation for functionality in docs/
  • Changes documented in CHANGELOG.md

from ._common import *
from ._numpy import *

Check notice

Code scanning / CodeQL

'import *' may pollute namespace Note

Import pollutes the enclosing namespace, as the imported module
sisl.typing._numpy
does not define '__all__'.
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 81.48148% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 86.68%. Comparing base (7dfe0ea) to head (0b3ad84).

❗ Current head 0b3ad84 differs from pull request most recent head a6667eb. Consider uploading reports for the commit a6667eb to get more accurate results

Files Patch % Lines
src/sisl/_core/orbital.py 71.42% 2 Missing ⚠️
src/sisl/io/xyz.py 66.66% 1 Missing ⚠️
src/sisl/typing/_atom.py 85.71% 1 Missing ⚠️
src/sisl/typing/_common.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #714   +/-   ##
=======================================
  Coverage   86.67%   86.68%           
=======================================
  Files         399      399           
  Lines       50718    50718           
=======================================
+ Hits        43960    43964    +4     
+ Misses       6758     6754    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zerothi
Copy link
Owner Author

zerothi commented Mar 18, 2024

I think I'll merge this, it isn't done, but it is a start! :)

zerothi added 3 commits March 19, 2024 10:27
also cleaned up some details when adding
more documentation for the basic things.

added more to the first tutorial which are
now in an nbgallery

restructure of the docs

Signed-off-by: Nick Papior <[email protected]>
changed header for publications

fixed lists and definition lists

created better alignment for noise_power

Signed-off-by: Nick Papior <[email protected]>
@zerothi zerothi force-pushed the 675-documentation branch from 164b65b to a6667eb Compare March 19, 2024 09:29
@zerothi zerothi merged commit e5f622a into main Mar 19, 2024
3 checks passed
@zerothi zerothi deleted the 675-documentation branch March 19, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation rework
1 participant