Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added code comments #4219

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

guonaihong
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.10%. Comparing base (8690859) to head (89e0ea3).
Report is 79 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
zrpc/internal/balancer/p2c/p2c.go 96.07% <ø> (+0.99%) ⬆️

... and 254 files with indirect coverage changes

@@ -121,6 +121,28 @@ func (p *p2cPicker) buildDoneFunc(c *subConn) func(info balancer.DoneInfo) {
if td < 0 {
td = 0
}

// The function curve of y = x^(-x) is as follows.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace this text curve with a chart link?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, under which repository of the zeromicro account should the image be placed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can put it in zero-doc

Copy link
Contributor Author

@guonaihong guonaihong Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zeromicro/zero-doc#179 Need to merge PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants