soc: nordic: nrf53: SOC_NRF53_CPUNET_ENABLE should not depend on !BT #79875
+1
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
anangl,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
This causes issues as we still want the net core to be set up on initialisation if CONFIG_BT is enabled in many cases. The previous changes in zephyrproject-rtos#74304 assumed that because this is also handled in `bt_hci_transport_setup` that it shouldn't be done on initialisation too. Also, I think that `bt_hci_transport_setup` should not be even controlling the network core state like it is currently and should be looked at being changed in a future PR. Signed-off-by: Sean Madigan <[email protected]>
sean-madigan
force-pushed
the
initialise_net_core_with_bt
branch
from
e28fa9c
to
10f4857
Compare
sean-madigan
added a commit
to sean-madigan/sdk-zephyr
that referenced
this pull request
Oct 15, 2024
… depend on !BT This causes issues as we still want the net core to be set up on initialisation if CONFIG_BT is enabled in many cases. The previous changes in zephyrproject-rtos/zephyr#74304 assumed that because this is also handled in `bt_hci_transport_setup` that it shouldn't be done on initialisation too. Also, I think that `bt_hci_transport_setup` should not be even controlling the network core state like it is currently and should be looked at being changed in a future PR. Upstream PR: zephyrproject-rtos/zephyr#79875 Signed-off-by: Sean Madigan <[email protected]>
Please create a GH issue to follow up, so that this request is not lost in the future... or do you already have PR you can link here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes issues as we still want the net core to be set up on initialisation if CONFIG_BT is enabled in many cases.
The previous changes in
#74304 assumed that because this is also handled in
bt_hci_transport_setupthat it shouldn't be done on initialisation too.Also, I think that
bt_hci_transport_setupshould not be even controlling the network core state like it is currently and should be looked at being changed in a future PR.