usb: device_next: USB CDC NCM class implementation #79508
+1,594
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jukkar
force-pushed
the
devel/usb-ncm
branch
2 times, most recently
from
f299a12
to
d1efbbf
Compare
|
zephyrbot
added
area: Sockets
zephyrbot
requested review from
decsny,
galak,
kartben,
lmajewski,
nashif,
pdgendt,
rlubos,
ssharks,
tbursztyka and
tmon-nordic
55 tasks
jfischer-no
reviewed
Oct 15, 2024
jfischer-no
changed the title
|
jfischer-no
reviewed
Oct 15, 2024
Comment on lines
794
to
795
| LOG_WRN("New configuration, interface %u alternate %u", | ||
| iface, alternate); |
There was a problem hiding this comment.
I think it should be LOG_INF, otherwise we will get bug reports for this.
LOG_INF("New configuration, interface %u alternate %u",
iface, alternate);
Comment on lines
917
to
923
| case SET_NTB_FORMAT: | ||
| LOG_DBG("SET_NTB_FORMAT"); | ||
| break; | ||
|
|
||
| case SET_ETHERNET_PACKET_FILTER: | ||
| LOG_DBG("SET_ETHERNET_PACKET_FILTER"); | ||
| break; |
There was a problem hiding this comment.
Missed that. Looks like typo, GET_NTB_FORMAT? (Needs to be implemented or removed if not required).
But there is no GET_ETHERNET_PACKET_FILTER.
(Set request, SET_.*, are handled above in the control-to-device requests. You will never get this kind of requests in control-to-host.)
| net_buf_add_mem(buf, &input_size, sizeof(input_size)); | ||
| break; | ||
| } | ||
| case SET_NTB_INPUT_SIZE: |
Comment on lines
946
to
950
| out: | ||
| if (ret < 0) { | ||
| errno = -ret; | ||
| } | ||
|
|
There was a problem hiding this comment.
It looks like you do not need ret at all.
USB NCM Ethernet driver implementation. Signed-off-by: Jukka Rissanen <[email protected]>
Add NCM class to sample usbd initialization and the code triple is set properly. Signed-off-by: Jukka Rissanen <[email protected]>
Add support for USB cdc_ncm to zperf application. Signed-off-by: Jukka Rissanen <[email protected]>
Add support for USB cdc_ncm to echo-server application. Signed-off-by: Jukka Rissanen <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements USB Network Control Model (NCM) driver for the USB next stack.
Following things are not implemented (yet):
How to try this: