Improve nxp csi mipicsi2rx drivers #76475
Open
+334
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josuah
added
priority: low
zephyrbot
requested review from
butok,
danieldegrasse,
dbaluta,
decsny,
DerekSnell,
EmilioCBen,
loicpoulain,
manuargue,
MarkWangChinese and
yvanderv
ngphibang
force-pushed
the
improve_nxp_csi_mipicsi2rx_drivers
branch
from
2f6a738
to
ece0adc
Compare
ngphibang
force-pushed
the
improve_nxp_csi_mipicsi2rx_drivers
branch
2 times, most recently
from
6aee5b6
to
23af338
Compare
trunghieulenxp
force-pushed
the
improve_nxp_csi_mipicsi2rx_drivers
branch
from
23af338
to
dcaf23c
Compare
|
Rebase because the PR #73009 is merged. |
trunghieulenxp
force-pushed
the
improve_nxp_csi_mipicsi2rx_drivers
branch
from
dcaf23c
to
406703f
Compare
trunghieulenxp
force-pushed
the
improve_nxp_csi_mipicsi2rx_drivers
branch
from
406703f
to
e3ad022
Compare
|
Rebase because the PR #76393 is merged |
@trunghieulenxp while you are welcome to rebase as much as you please, it may not be worth bothering to do so until the dependent PRs are merged, especially if CI will fail until that point. If a change is large I'll often review it before CI is passing, but in this case the change is primarily at the driver level, so it likely won't generate a ton of engagement until CI can pass. |
ngphibang
force-pushed
the
improve_nxp_csi_mipicsi2rx_drivers
branch
from
e3ad022
to
1263f40
Compare
|
Updated according changes in #74415. @danieldegrasse : Yes, but since there are new changes comming, we update it regularly to not forget things :). Another reason is to cooperate with this PR. |
trunghieulenxp
force-pushed
the
improve_nxp_csi_mipicsi2rx_drivers
branch
2 times, most recently
from
8e6411d
to
6860d6f
Compare
As getting bytes per pixel of a pixel format is a very common operation, add an utility function for it instead of repeating the same codes in different drivers. Signed-off-by: Phi Bang Nguyen <[email protected]>
Remove the obsolete comment about the init order of the CSI and the camera sensors (e.g. mt9m114) which is not true anymore. Signed-off-by: Phi Bang Nguyen <[email protected]>
When stopping, video_flush() moves all the remaining buffers from the fifo_in to the fifo_out queue. When restarting, we have two issues: - There might be insufficient or no buffers in the fifo_in queue to get the pipeline started. - When dequeuing, users might immediatly get the incorrect buffers in the fifo_out which do not come from interruption. Fix it by moving all the remaining buffers from the fifo_out to the fifo_in before starting the video capture. Signed-off-by: Trung Hieu Le <[email protected]> Signed-off-by: Phi Bang Nguyen <[email protected]>
Add support for changing frame rate Signed-off-by: Trung Hieu Le <[email protected]> Signed-off-by: Phi Bang Nguyen <[email protected]>
The mcux csi is an NXP IP and the driver has been recently changed much by NXP, so add NXP copyright to it. Signed-off-by: Phi Bang Nguyen <[email protected]>
Switch to use the new video interfaces bindings Signed-off-by: Phi Bang Nguyen <[email protected]>
Switch to use the new video interfaces bindings Signed-off-by: Phi Bang Nguyen <[email protected]>
Switch to use the new video interfaces binding Signed-off-by: Phi Bang Nguyen <[email protected]>
Switch to use the new video interfaces binding Signed-off-by: Phi Bang Nguyen <[email protected]>
The ov5640 camera driver now supports both MIPI CSI2 (DPHY) and DVP modes. It is in MIPI CSI2 mode in this overlay. Add bus-type property for this. In this mode, data-lanes property is required as well. Signed-off-by: Phi Bang Nguyen <[email protected]>
Get number of data lanes from device tree instead of hard-coding it. Signed-off-by: Phi Bang Nguyen <[email protected]>
Add set_ctrl callback to propagate controls to the sensor. Signed-off-by: Farah Fliss <[email protected]> Signed-off-by: Phi Bang Nguyen <[email protected]>
Instead of fixing csi2rx clock frequencies, set them according to the pixel rate got from the camera sensor. Signed-off-by: Trung Hieu Le <[email protected]> Signed-off-by: Phi Bang Nguyen <[email protected]>
Add support for changing frame rate. Signed-off-by: Trung Hieu Le <[email protected]> Signed-off-by: Phi Bang Nguyen <[email protected]>
trunghieulenxp
force-pushed
the
improve_nxp_csi_mipicsi2rx_drivers
branch
from
6860d6f
to
9e872df
Compare
|
As dependencies are now merged, could you help to review this to move this PR along ? @danieldegrasse , @josuah , @loicpoulain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the NXP's csi and mipi_csi2_rx drivers which contains some minor fixes, optimization and especially, support for changing frame rate.
This PR depends on #74415 and #72254, also relates to #76144