Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: canaan: Add initial support for canmv_k230 #74169

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Judehahh
Copy link

Add DTS and SoC support for Canaan K230 Soc
Add board support for CanMV-K230

depends on thead,machine-timer driver in #69594

Copy link

Hello @Judehahh, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@kartben
Copy link
Collaborator

kartben commented Jun 12, 2024

@Judehahh thanks for your PR! In order to set expectations, please note that the feature freeze for Zephyr 3.7 is coming up this Friday, June 14, so there's a high chance your PR might not make into this release, and it might also be a slightly longer than usual until it gets an initial review due to maintainers being busy with release stuff :)

@decsny decsny removed their request for review June 12, 2024 15:51
Copy link
Member

@ycsin ycsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine to me, but this needs a rebase (not merge), and the commits should be splitted into multiple logical commits (see #56370)

@Judehahh Judehahh requested a review from ycsin June 25, 2024 15:03
@Judehahh
Copy link
Author

The code looks fine to me, but this needs a rebase (not merge), and the commits should be splitted into multiple logical commits (see #56370)

Thanks, I will rebase when the dependent PR is merged and split it into multiple logical commits.

And I'm so sorry I pressed the "request review" button by mistake...

@kartben
Copy link
Collaborator

kartben commented Aug 9, 2024

@Judehahh will you be coming back to this PR?

@Judehahh
Copy link
Author

@kartben Yes, I will update once the dependency is merged.

select RISCV_ISA_RV64I
select RISCV_ISA_EXT_G
select RISCV_ISA_EXT_C

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update it when rebase

Comment on lines +13 to +16
default "k230" if SOC_SERIES_CANAAN_K230

config SOC
default "k230" if SOC_CANAAN_K230
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the text here, it needs to match the symbol, if you have k230 then you need SOC_SERIES_K230/SOC_K230, if you have canaan_k280 then you need SOC_SERIES_CANAAN_K230/SOC_CANAAN_K230

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, I'll update it when rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Devicetree Binding PR modifies or adds a Device Tree binding area: Process area: RISCV RISCV Architecture (32-bit & 64-bit)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants