-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards: canaan: Add initial support for canmv_k230 #74169
base: main
Are you sure you want to change the base?
Conversation
Hello @Judehahh, and thank you very much for your first pull request to the Zephyr project! |
@Judehahh thanks for your PR! In order to set expectations, please note that the feature freeze for Zephyr 3.7 is coming up this Friday, June 14, so there's a high chance your PR might not make into this release, and it might also be a slightly longer than usual until it gets an initial review due to maintainers being busy with release stuff :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine to me, but this needs a rebase (not merge), and the commits should be splitted into multiple logical commits (see #56370)
Thanks, I will rebase when the dependent PR is merged and split it into multiple logical commits. And I'm so sorry I pressed the "request review" button by mistake... |
@Judehahh will you be coming back to this PR? |
@kartben Yes, I will update once the dependency is merged. |
select RISCV_ISA_RV64I | ||
select RISCV_ISA_EXT_G | ||
select RISCV_ISA_EXT_C | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update it when rebase
default "k230" if SOC_SERIES_CANAAN_K230 | ||
|
||
config SOC | ||
default "k230" if SOC_CANAAN_K230 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the text here, it needs to match the symbol, if you have k230 then you need SOC_SERIES_K230/SOC_K230, if you have canaan_k280 then you need SOC_SERIES_CANAAN_K230/SOC_CANAAN_K230
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, I'll update it when rebase
Add DTS and SoC support for Canaan K230 Soc
Add board support for CanMV-K230
depends on
thead,machine-timer
driver in #69594