Skip to content

Convert NXP EDMA compats by version to property #154952

Convert NXP EDMA compats by version to property

Convert NXP EDMA compats by version to property #154952

Triggered via pull request October 15, 2024 14:42
Status Success
Total duration 2m 42s
Artifacts 1

compliance.yml

on: pull_request
Run compliance checks on patch series (PR)
2m 33s
Run compliance checks on patch series (PR)
Fit to window
Zoom out
Zoom in

Annotations

1 error, 1 warning, and 3 notices
Run compliance checks on patch series (PR)
Process completed with exit code 1.
Run compliance checks on patch series (PR): ClangFormat.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details. You may want to run clang-format on this change: -#define HAS_CHANNEL_GAP(n) DT_INST_PROP(n, channel_gap) || +#define HAS_CHANNEL_GAP(n) DT_INST_PROP(n, channel_gap) || File:drivers/dma/dma_mcux_edma.c Line:31 You may want to run clang-format on this change: -#define DMA_MCUX_EDMA_CONFIG_FUNC(n) \ - LISTIFY(NUM_IRQS_WITHOUT_ERROR_IRQ(n), DMA_MCUX_EDMA_IRQ_DEFINE, (), n) \ - static void dma_imx_config_func_##n(const struct device *dev) \ - { \ - ARG_UNUSED(dev); \ - \ +#define DMA_MCUX_EDMA_CONFIG_FUNC(n) \ + LISTIFY(NUM_IRQS_WITHOUT_ERROR_IRQ(n), DMA_MCUX_EDMA_IRQ_DEFINE, (), n) \ + static void dma_imx_config_func_##n(const struct device *dev) \ + { \ + ARG_UNUSED(dev); \ + \ LISTIFY(NUM_IRQS_WITHOUT_ERROR_IRQ(n), \ - DMA_MCUX_EDMA_IRQ_CONFIG, (;), n) \ - \ + DMA_MCUX_EDMA_IRQ_CONFIG, (;), n) \ + \ IF_ENABLED(UTIL_NOT(DT_INST_PROP(n, no_error_irq)), \ (IRQ_CONFIG(n, NUM_IRQS_WITHOUT_ERROR_IRQ(n), \ - dma_mcux_edma_error_irq_handler))) \ - \ - LOG_DBG("install irq done"); \ + dma_mcux_edma_error_irq_handler))) \ + \ + LOG_DBG("install irq done"); \ File:drivers/dma/dma_mcux_edma.c Line:677 You may want to run clang-format on this change: -#define DMA_INIT(n) \ - DMAMUX_BASE_INIT_DEFINE(n) \ - DMA_MCUX_EDMA_CONFIG_FUNC(n) \ - static const struct dma_mcux_edma_config dma_config_##n = { \ - .base = (DMA_Type *)DT_INST_REG_ADDR(n), \ - DMAMUX_BASE_INIT(n) \ - .dma_channels = DT_INST_PROP(n, dma_channels), \ - CHANNELS_PER_MUX(n) \ - .irq_config_func = dma_imx_config_func_##n, \ - .dmamux_reg_offset = DT_INST_PROP(n, dmamux_reg_offset), \ - DMA_MCUX_EDMA_CHANNEL_GAP(n) \ - }; \ - \ - struct dma_mcux_edma_data dma_data_##n; \ - \ - DEVICE_DT_INST_DEFINE(n, \ - &dma_mcux_edma_init, NULL, \ - &dma_data_##n, &dma_config_##n, \ - PRE_KERNEL_1, CONFIG_DMA_INIT_PRIORITY, \ - &dma_mcux_edma_api); +#define DMA_INIT(n) \ + DMAMUX_BASE_INIT_DEFINE(n) \ + DMA_MCUX_EDMA_CONFIG_FUNC(n) \ + static const struct dma_mcux_edma_config dma_config_##n = { \ + .base = (DMA_Type *)DT_INST_REG_ADDR(n), \ + DMAMUX_BASE_INIT(n).dma_channels = DT_INST_PROP(n, dma_channels), \ + CHANNELS_PER_MUX(n).irq_config_func = dma_imx_config_func_##n, \ + .dmamux_reg_offset = DT_INST_PROP(n, dmamux_reg_offset), \ + DMA_MCUX_EDMA_CHANNEL_GAP(n)}; \ + \ + struct dma_mcux_edma_data dma_data_##n; \ + \ + DEVICE_DT_INST_DEFINE(n, &dma_mcux_edma_init, NULL, &dma_data_##n, &dma_config_
You may want to run clang-format on this change: drivers/dma/dma_mcux_edma.c#L31
drivers/dma/dma_mcux_edma.c:31 -#define HAS_CHANNEL_GAP(n) DT_INST_PROP(n, channel_gap) || +#define HAS_CHANNEL_GAP(n) DT_INST_PROP(n, channel_gap) ||
You may want to run clang-format on this change: drivers/dma/dma_mcux_edma.c#L677
drivers/dma/dma_mcux_edma.c:677 -#define DMA_MCUX_EDMA_CONFIG_FUNC(n) \ - LISTIFY(NUM_IRQS_WITHOUT_ERROR_IRQ(n), DMA_MCUX_EDMA_IRQ_DEFINE, (), n) \ - static void dma_imx_config_func_##n(const struct device *dev) \ - { \ - ARG_UNUSED(dev); \ - \ +#define DMA_MCUX_EDMA_CONFIG_FUNC(n) \ + LISTIFY(NUM_IRQS_WITHOUT_ERROR_IRQ(n), DMA_MCUX_EDMA_IRQ_DEFINE, (), n) \ + static void dma_imx_config_func_##n(const struct device *dev) \ + { \ + ARG_UNUSED(dev); \ + \ LISTIFY(NUM_IRQS_WITHOUT_ERROR_IRQ(n), \ - DMA_MCUX_EDMA_IRQ_CONFIG, (;), n) \ - \ + DMA_MCUX_EDMA_IRQ_CONFIG, (;), n) \ + \ IF_ENABLED(UTIL_NOT(DT_INST_PROP(n, no_error_irq)), \ (IRQ_CONFIG(n, NUM_IRQS_WITHOUT_ERROR_IRQ(n), \ - dma_mcux_edma_error_irq_handler))) \ - \ - LOG_DBG("install irq done"); \ + dma_mcux_edma_error_irq_handler))) \ + \ + LOG_DBG("install irq done"); \
You may want to run clang-format on this change: drivers/dma/dma_mcux_edma.c#L730
drivers/dma/dma_mcux_edma.c:730 -#define DMA_INIT(n) \ - DMAMUX_BASE_INIT_DEFINE(n) \ - DMA_MCUX_EDMA_CONFIG_FUNC(n) \ - static const struct dma_mcux_edma_config dma_config_##n = { \ - .base = (DMA_Type *)DT_INST_REG_ADDR(n), \ - DMAMUX_BASE_INIT(n) \ - .dma_channels = DT_INST_PROP(n, dma_channels), \ - CHANNELS_PER_MUX(n) \ - .irq_config_func = dma_imx_config_func_##n, \ - .dmamux_reg_offset = DT_INST_PROP(n, dmamux_reg_offset), \ - DMA_MCUX_EDMA_CHANNEL_GAP(n) \ - }; \ - \ - struct dma_mcux_edma_data dma_data_##n; \ - \ - DEVICE_DT_INST_DEFINE(n, \ - &dma_mcux_edma_init, NULL, \ - &dma_data_##n, &dma_config_##n, \ - PRE_KERNEL_1, CONFIG_DMA_INIT_PRIORITY, \ - &dma_mcux_edma_api); +#define DMA_INIT(n) \ + DMAMUX_BASE_INIT_DEFINE(n) \ + DMA_MCUX_EDMA_CONFIG_FUNC(n) \ + static const struct dma_mcux_edma_config dma_config_##n = { \ + .base = (DMA_Type *)DT_INST_REG_ADDR(n), \ + DMAMUX_BASE_INIT(n).dma_channels = DT_INST_PROP(n, dma_channels), \ + CHANNELS_PER_MUX(n).irq_config_func = dma_imx_config_func_##n, \ + .dmamux_reg_offset = DT_INST_PROP(n, dmamux_reg_offset), \ + DMA_MCUX_EDMA_CHANNEL_GAP(n)}; \ + \ + struct dma_mcux_edma_data dma_data_##n; \ + \ + DEVICE_DT_INST_DEFINE(n, &dma_mcux_edma_init, NULL, &dma_data_##n, &dma_config_##n, \ + PRE_KERNEL_1, CONFIG_DMA_INIT_PRIORITY, &dma_mcux_edma_api);

Artifacts

Produced during runtime
Name Size
compliance.xml
1.35 KB