nrf_wifi: Create dedicated memory pools for Wi-Fi #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create dedicated memory pools for Wi-Fi data and management paths. Introduce corresponding memory allocation/deallocation calls. Signed-off-by: Ravi Dondaputi <[email protected]>
rado17
requested review from
krish2718,
sachinthegreen and
jukkar
as code owners
krish2718
reviewed
Sep 17, 2024
| @@ -66,6 +66,20 @@ void *nrf_wifi_osal_mem_alloc(size_t size); | |||
| */ | |||
| void *nrf_wifi_osal_mem_zalloc(size_t size); | |||
|
|
|||
|
|
|||
| /** | |||
| * @brief Allocated zero-initialized memory for data. | |||
There was a problem hiding this comment.
should we add ctrl in the doxygen headers for the default APIs?
sachinthegreen
requested changes
Sep 20, 2024
There was a problem hiding this comment.
@rado17 : As per the last discussion aren't we going to change the generic memory API's to take the pool_type as a parameter (rather than create separate APIs for each pool type) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create dedicated memory pools for Wi-Fi data and
management paths. Introduce corresponding memory
allocation/deallocation calls.