Ensure Santa ballot unicity across realms #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that not only a ballot from the same realm user is a match, but also a ballot from a different realm user with the same username. This avoids double votes with 2 SAML apps with different scopes (All the employees for the portal, only the admins for the Zentral console) but from the same IdP, so with the same usernames.
Pull Request Test Coverage Report for Build 11937071451Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that not only a ballot from the same realm user is a match, but also a ballot from a different realm user with the same username. This avoids double votes in the case of 2 SAML apps with different scopes (All the employees for the portal, only the admins for the Zentral console) but from the same IdP, so with the same usernames.