Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

20241030 updates #1072

Merged
merged 2 commits into from
Oct 30, 2024
Merged

20241030 updates #1072

merged 2 commits into from
Oct 30, 2024

Conversation

np5
Copy link
Member

@np5 np5 commented Oct 30, 2024

No description provided.

np5 added 2 commits October 30, 2024 12:22
@np5
Better realms navigation
886ada4
@np5
Fix Santa forms
be4daed 
 - Add custom target types widget
 - Avoid realm group conflicts on voting groups
 - Add voting group views tests
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11592234684

Details

  • 23 of 28 (82.14%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 80.827%
Changes Missing Coverage Covered Lines Changed/Added Lines %
server/realms/views.py 10 15 66.67%
Files with Coverage Reduction New Missed Lines %
server/realms/views.py 1 85.02%
Totals Coverage Status
Change from base Build 11571110095: 0.05%
Covered Lines: 38389
Relevant Lines: 47495
💛 - Coveralls

headmin
headmin approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@headmin headmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@np5 np5 merged commit be4daed into main Oct 30, 2024
10 checks passed
@np5 np5 deleted the 20241030_updates branch October 30, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@headmin headmin headmin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@np5 @coveralls @headmin