Refactor implementation to use AppKit for handling windows #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Cleanup AppDelegate - Reduce complexity in KeyboardCowboyApp - Add new `WindowOpener` class for opening windows inside SwiftUI
Change font in the workflow name from headline to title2 and make it bold Fix issue with titlebar in the main window by setting .unifiedCompact Add animation to new command window and fix centering of the window
Remove unused scene components Style empty configuration, new command window, permissions & permission settings Remove holding references in window opener Bump version to 3.25.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes fixes for high CPU uses and aims to reduce the memory footprint by taking control over the applications window lifecycle. This is achieved by moving from
SwiftUIwindow handling over to anNSWindow-based approach where the content view of the window is aSwiftUIview.This PR also includes other minor bug fixes related to both UI and UX.