Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Environment Variable Resolution Logic #473

Merged
merged 2 commits into from
Dec 12, 2023

Refactor resolving environment variables logic to enhance naming

f3758e1
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Refactor Environment Variable Resolution Logic #473

Refactor resolving environment variables logic to enhance naming
f3758e1
Select commit
Loading
Failed to load commit list.
GitHub Actions / Xcode test results succeeded Dec 12, 2023 in 0s

Xcode test results

Testing workspace Keyboard Cowboy with scheme Keyboard-Cowboy

Summary

TotalSuccess PassedFailure FailedSkipped SkippedExpected Failure Expected Failure⏱️ Time
39390000.15s

Test Summary

UnitTests

  • Device: Mac mini, 13.6.1 (22G313)
  • SDK: macOS 14.0, 14.0
TestTotalSuccessFailureSkippedExpected Failure
test-class ApplicationTriggerControllerTests33000
test-class ApplicationTriggerTests11000
test-class CommandTests11000
test-class ContentViewActionReducerTests55000
test-class DropCommandsControllerTests55000
test-class KeyShortcutTests99000
test-class KeyboardShortcutTriggerTests11000
test-class KeyboardShortcutsControllerTests11000
test-class WorkflowTests1313000

Failure Failures

All tests passed 🎉


Code Coverage

Coverage Covered Executable
Keyboard Cowboy.app 6.36 % 2331 36672
  NotificationView.swift 0.00 % 0 57
  MenuBarCommand.swift 24.00 % 6 25
  AutoCompletionView.swift 0.00 % 0 79
  NewCommandWindow.swift 18.14 % 39 215
  WindowManagementAnimationDurationView.swift 0.00 % 0 103
  OpenFilePlugin.swift 21.43 % 3 14
  AppUpdater.swift 40.00 % 4 10
  AccessibilityPermission.swift 40.86 % 38 93
  SidebarLabelStyle.swift 0.00 % 0 16
  ApplicationCommandView.swift 0.00 % 0 280
  ContentHeaderView.swift 0.00 % 0 69
  IntegerTextField.swift 0.00 % 0 26
  NewCommandScriptView.swift 0.00 % 0 380
  ContentItemIsDisabledOverlayView.swift 0.00 % 0 25
  MutableCollection+Extensions.swift 0.00 % 0 41
  DesignTimePublishers.swift 0.00 % 0 247
  ContentTypeImageView.swift 0.00 % 0 15
  NewCommandMenuBarView.swift 0.00 % 0 683
  GroupSymbol.swift 0.00 % 0 212
  Command+Name.swift 43.59 % 34 78
  WorkflowNotificationMatchesView.swift 0.00 % 0 115
  WindowCommandRunner.swift 0.88 % 6 682
  ContentAddWorkflowHeaderView.swift 0.00 % 0 30
  MenuBarCommandRunner.swift 1.54 % 1 65
  CommandContainerView.swift 0.00 % 0 392
  ContentListEmptyView.swift 0.00 % 0 143
  BezelNotificationCoordinator.swift 0.00 % 0 4
  AppStorageContainer.swift 100.00 % 9 9
  Storage.swift 6.45 % 6 93
  PermissionsSettings.swift 1.48 % 2 135
  NSColor+Extensions.swift 0.00 % 0 32
  SymbolPalette.swift 0.00 % 0 138
  WorkflowTriggerListView.swift 0.00 % 0 139
  PermissionsScene.swift 100.00 % 29 29
  ConfigurationStore.swift 4.69 % 3 64
  DetailModelMapper.swift 1.58 % 3 190
  MouseMonitor.swift 48.48 % 16 33
  SidebarCoordinator.swift 26.44 % 46 174
  ScriptCommand.swift 13.33 % 6 45
  DetailCommandContainerActionReducer.swift 0.00 % 0 15
  AddUserModeView.swift 0.00 % 0 45
  SplashView.swift 0.00 % 0 204
  WindowRunnerFullscreen.swift 0.00 % 0 63
  NewCommandValidation.swift 0.00 % 0 27
  SidebarAddGroupButtonView.swift 0.00 % 0 53
  GroupItemView.swift 0.00 % 0 170
  ContentScriptImageView.swift 0.00 % 0 60
  WorkflowNotificationView.swift 0.00 % 0 186
  AXCollectionResolver.swift 0.00 % 0 32
  MachPortUINotifications.swift 10.87 % 10 92
  WorkflowNotificationController.swift 0.00 % 0 40
  FileWatcher.swift 0.00 % 0 30
  CommandKeyIcon.swift 0.00 % 0 79
  UserModesRunner.swift 0.00 % 0 29
  DetailViewActionReducer.swift 0.00 % 0 176
  ContentViewActionReducer.swift 67.35 % 33 49
  FileMenu.swift 100.00 % 11 11
  MachPortCoordinator.swift 3.68 % 12 326
  URLIcon.swift 0.00 % 0 98
  OpenPanelController.swift 2.44 % 1 41
  UserModesBezelController.swift 81.25 % 13 16
  AXEditorResolver.swift 0.00 % 0 23
  WindowCommand.swift 3.29 % 5 152
  BuiltInCommandRunner.swift 30.00 % 3 10
  DebounceManager.swift 0.00 % 0 11
  KeyCodesStore.swift 16.67 % 7 42
  DebugGenerator.swift 0.00 % 0 41
  DraggableView.swift 0.00 % 0 16
  ContentImagesView.swift 0.00 % 0 76
  DropCommandsController.swift 98.04 % 50 51
  ShortcutCommand.swift 21.05 % 4 19
  Command.swift 27.69 % 72 260
  KeyShortcut.swift 100.00 % 40 40
  ColorPalette.swift 0.00 % 0 73
  CustomApplicationRoutine.swift 0.00 % 0 6
  CommandSymbol.swift 0.00 % 0 134
  WorkflowCommandListView.swift 0.00 % 0 41
  FolderSymbol.swift 0.00 % 0 306
  TuistBundle+KeyboardCowboy.swift 0.00 % 0 3
  NewCommandShortcutView.swift 0.00 % 0 131
  DebounceSelectionManager.swift 0.00 % 0 20
  TextCommand.swift 35.90 % 14 39
  NewCommandApplicationView.swift 0.00 % 0 344
  MouseCommandRunner.swift 0.00 % 0 122
  CloseApplicationPlugin.swift 15.79 % 3 19
  ContentIconImageView.swift 0.00 % 0 27
  FeatureIcon.swift 0.00 % 0 99
  RuleHeaderView.swift 0.00 % 0 117
  Core.swift 88.51 % 77 87
  AddButtonView.swift 0.00 % 0 110
  KeyboardCommandRunner.swift 5.45 % 3 55
  ApplicationTrigger.swift 47.62 % 10 21
  WorkflowTriggerView.swift 0.00 % 0 287
  WindowRunnerIncreaseWindowSize.swift 0.00 % 0 75
  WifiInfo.swift 0.00 % 0 26
  NewCommandBuiltInView.swift 0.00 % 0 158
  SidebarConfigurationHeaderView.swift 0.00 % 0 7
  LaunchApplicationPlugin.swift 18.75 % 3 16
  TypingSymbol.swift 0.00 % 0 51
  MissionControlPlugin.swift 9.38 % 3 32
  EditableKeyboardShortcutsView.swift 0.00 % 0 780
  NewCommandImageView.swift 0.00 % 0 88
  ApplicationStore.swift 37.98 % 49 129
  SBFinder.swift 0.00 % 0 24
  WindowCommandRunner+Helpers.swift 0.00 % 0 32
  AXScrollAreaResolver.swift 0.00 % 0 37
  DetailCommandActionReducer.swift 0.00 % 0 291
  WorkflowCommandListScrollView.swift 0.00 % 0 263
  WindowRunnerDecreaseWindowSize.swift 0.00 % 0 34
  WorkflowOuputView.swift 0.00 % 0 98
  EditConfigurationView.swift 0.00 % 0 118
  OpenApplicationWithNoWindowsSystemRoutine.swift 0.00 % 0 17
  KeyboardCowboyConfiguration.swift 7.07 % 14 198
  AutoCompletionStore.swift 0.00 % 0 5
  PermissionsView.swift 0.64 % 2 313
  CommandRunner.swift 8.64 % 26 301
  TuistAssets+KeyboardCowboy.swift 0.00 % 0 40
  WindowRunnerAnchorWindow.swift 0.00 % 0 449
  Icon+Extensions.swift 0.00 % 0 3
  KeyboardCowboy+Extensions.swift 50.00 % 11 22
  CustomMouseRoutine.swift 0.00 % 0 5
  AXGroupResolver.swift 0.00 % 0 27
  BringToFrontApplicationPlugin.swift 13.64 % 3 22
  MouseCommand.swift 0.00 % 0 89
  TypeCommandView.swift 0.00 % 0 143
  SidebarMapper.swift 0.00 % 0 26
  WorkflowApplicationTriggerView.swift 0.00 % 0 316
  TextCommandRunner.swift 7.14 % 3 42
  CommandView.swift 0.00 % 0 340
  ContentListFilterView.swift 0.00 % 0 107
  View+Extensions.swift 0.00 % 0 179
  KeyShortcutRecorderStore.swift 0.00 % 0 10
  WorkflowShortcutsView.swift 0.00 % 0 50
  NewCommandButtonView.swift 0.00 % 0 18
  DropItem.swift 0.00 % 0 18
  StorageConfiguration.swift 57.14 % 4 7
  Rule.swift 0.00 % 0 13
  LoginItem.swift 13.64 % 3 22
  SystemInfo.swift 0.00 % 0 17
  AppDelegate.swift 81.82 % 9 11
  EditableKeyboardShortcutsItemView.swift 0.00 % 0 139
  KeyboardShortcutTrigger.swift 100.00 % 11 11
  Workflow.swift 45.50 % 86 189
  KeyboardCowboyEngine.swift 32.18 % 28 87
  DesignTime+Extensions.swift 0.00 % 0 133
  Binding+Extensions.swift 0.00 % 0 8
  ContentShortcutImageView.swift 0.00 % 0 19
  AXTableResolver.swift 0.00 % 0 19
  WindowListStore.swift 0.00 % 0 7
  CommandViewModel.swift 0.00 % 0 17
  XcodeMouseRoutine.swift 0.00 % 0 44
  WorkflowGroup.swift 20.90 % 14 67
  WindowRunnerCenterWindow.swift 0.00 % 0 81
  FeatureBetaModifier.swift 0.00 % 0 309
  ContentCoordinator.swift 10.69 % 17 159
  ApplicationTriggerController.swift 95.16 % 118 124
  KeyboardView.swift 0.00 % 0 780
  WindowRunnerMoveToNextDisplayRelative.swift 0.00 % 0 54
  AppMenu.swift 90.00 % 9 10
  WorkflowCommandListHeaderView.swift 0.00 % 0 83
  WindowManagementAnimationPopoverView.swift 0.00 % 0 88
  NotificationWindow.swift 0.00 % 0 36
  GeometryPreferenceKeyView.swift 0.00 % 0 9
  ApplicationCommandRunner.swift 15.63 % 10 64
  ApplicationSettingsView.swift 0.84 % 3 358
  OpenURLParser.swift 0.00 % 0 16
  AXHTMLResolver.swift 0.00 % 0 44
  ApplicationCommand.swift 47.37 % 18 38
  WindowManagementCommandView.swift 0.00 % 0 1767
  DetailEmptyView.swift 0.00 % 0 7
  DetailViewModel.swift 0.00 % 0 37
  Array+Extensions.swift 0.00 % 0 28
  FolderIcon.swift 0.00 % 0 285
  GroupsView.swift 0.00 % 0 30
  BuildInCommand.swift 35.14 % 13 37
  KeyBackgroundView.swift 0.00 % 0 37
  SidebarNewConfigurationPopoverView.swift

Details

Test Details

UnitTestsback

ApplicationTriggerControllerTests back

SuccessFailureSkippedExpected Failure⏱️
3 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testApplicationTriggerController_closed()
Successtest-method testApplicationTriggerController_frontMost()
Successtest-method testApplicationTriggerController_launched()

ApplicationTriggerTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testCopy()

CommandTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testCopy()

ContentViewActionReducerTests back

SuccessFailureSkippedExpected Failure⏱️
5 (100%)0 (0%)0 (0%)0 (0%)0.02s
Successtest-method testReduceContentViewAction_addWorkflow()
Successtest-method testReduceContentViewAction_moveWorkflows()
Successtest-method testReduceContentViewAction_moveWorkflowsToGroup()
Successtest-method testReduceContentViewAction_noop()
Successtest-method testReduceContentViewAction_removeWorflows()

DropCommandsControllerTests back

SuccessFailureSkippedExpected Failure⏱️
5 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testGeneratingAppleScriptCommand()
Successtest-method testGeneratingApplicationCommand()
Successtest-method testGeneratingFileCommand()
Successtest-method testGeneratingShellScriptCommand()
Successtest-method testGeneratingWebCommand()

KeyShortcutTests back

SuccessFailureSkippedExpected Failure⏱️
9 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testEmptyMethod()
Successtest-method testFromDecoder_ID_Key_Data()
Successtest-method testFromDecoder_ID_Key_LHS_Data()
Successtest-method testFromDecoder_ID_Key_LHS_Modifier_Data()
Successtest-method testFromDecoder_ID_Key_LHS_Modifiers_Data()
Successtest-method testFromDecoder_Key_Data()
Successtest-method testModifersDisplayValue()
Successtest-method testStringValue()
Successtest-method testValidationValue()

KeyboardShortcutTriggerTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testCopy()

KeyboardShortcutsControllerTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.12s
Successtest-method testLookupInLargeCollection()

WorkflowTests back

SuccessFailureSkippedExpected Failure⏱️
13 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testCopy()
Successtest-method testResolveUserEnvironmentForApplication()
Successtest-method testResolveUserEnvironmentForBuiltInCommands()
Successtest-method testResolveUserEnvironmentForKeyboardCommands()
Successtest-method testResolveUserEnvironmentForMenuBarCommands()
Successtest-method testResolveUserEnvironmentForMouseCommands()
Successtest-method testResolveUserEnvironmentForOpenCommand_path()
Successtest-method testResolveUserEnvironmentForScriptCommand_inline()
Successtest-method testResolveUserEnvironmentForScriptCommand_path()
Successtest-method testResolveUserEnvironmentForShortcutCommands()
Successtest-method testResolveUserEnvironmentForSystemCommand()
Successtest-method testResolveUserEnvironmentForTextCommand()
Successtest-method testResolveUserEnvironmentForWindowManagement()