Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs on macOS Ventura #461

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Fix bugs on macOS Ventura #461

merged 2 commits into from
Dec 5, 2023

Conversation

zenangst
Copy link
Owner

@zenangst zenangst commented Dec 5, 2023

  • Refactor handling of tab key events in WorkflowInfoView
  • Fix tap gesture on macOS Ventura

Fixes #459

Extracted tab key event handling into a new view modifier, `TabModifier`, to improve readability and maintainability of the SwiftUI view code. Previously, the `WorkflowInfoView` was directly managing the subscription to keyboard events, complicating its structure. Now, the logic for handling tab key press events is encapsulated in the `TabModifier`.

On Ventura, this causes a recursion, so the view modifier is scoped to Sonoma and newer.
Copy link

github-actions bot commented Dec 5, 2023

@zenangst zenangst merged commit aa0bb8b into main Dec 5, 2023
2 checks passed
@zenangst zenangst deleted the fix/ventura-bugs branch December 5, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crashes when trying to add workflow
1 participant