Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature notification when running commands & other improvements #419

Merged
merged 12 commits into from
Oct 16, 2023

Reset the front most index when switching applications

ec660b2
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Feature notification when running commands & other improvements #419

Reset the front most index when switching applications
ec660b2
Select commit
Loading
Failed to load commit list.
GitHub Actions / Xcode test results succeeded Oct 16, 2023 in 0s

Xcode test results

Testing workspace Keyboard Cowboy with scheme Keyboard-Cowboy

Summary

TotalSuccess PassedFailure FailedSkipped SkippedExpected Failure Expected Failure⏱️ Time
27270000.11s

Test Summary

UnitTests

  • Device: Mac mini, 13.6 (22G120)
  • SDK: macOS 14.0, 14.0
TestTotalSuccessFailureSkippedExpected Failure
test-class ApplicationTriggerControllerTests33000
test-class ApplicationTriggerTests11000
test-class CommandTests11000
test-class ContentViewActionReducerTests55000
test-class DropCommandsControllerTests55000
test-class KeyShortcutTests99000
test-class KeyboardShortcutTriggerTests11000
test-class KeyboardShortcutsControllerTests11000
test-class WorkflowTests11000

Failure Failures

All tests passed 🎉

Code Coverage

Coverage Covered Executable
Keyboard Cowboy.app 4.93 % 1571 31874
  NotificationView.swift 0.00 % 0 57
  MenuBarCommand.swift 0.00 % 0 25
  WindowRunnerAnchorWindow.swift 0.00 % 0 450
  AutoCompletionView.swift 0.00 % 0 79
  NewCommandWindow.swift 18.45 % 38 206
  WindowManagementAnimationDurationView.swift 0.00 % 0 102
  OpenFilePlugin.swift 0.00 % 0 14
  SidebarLabelStyle.swift 0.00 % 0 16
  AccessibilityPermission.swift 0.00 % 0 93
  AppUpdater.swift 40.00 % 4 10
  ApplicationCommandView.swift 0.00 % 0 242
  ContentHeaderView.swift 0.00 % 0 69
  NewCommandScriptView.swift 0.00 % 0 338
  IntegerTextField.swift 0.00 % 0 26
  ContentItemIsDisabledOverlayView.swift 0.00 % 0 25
  DesignTimePublishers.swift 0.00 % 0 197
  ContentTypeImageView.swift 0.00 % 0 15
  MoveManager.swift 0.00 % 0 22
  NewCommandMenuBarView.swift 0.00 % 0 683
  GroupSymbol.swift 0.00 % 0 212
  Command+Name.swift 67.12 % 49 73
  NSEventController.swift 0.00 % 0 21
  WorkflowNotificationMatchesView.swift 0.00 % 0 115
  WindowCommandRunner.swift 0.00 % 0 671
  ContentAddWorkflowHeaderView.swift 0.00 % 0 32
  MenuBarCommandRunner.swift 0.00 % 0 65
  CommandContainerView.swift 0.00 % 0 391
  ContentListEmptyView.swift 0.00 % 0 143
  BezelNotificationCoordinator.swift 0.00 % 0 4
  Storage.swift 7.32 % 6 82
  PermissionsSettings.swift 1.47 % 2 136
  NSColor+Extensions.swift 0.00 % 0 32
  SymbolPalette.swift 0.00 % 0 99
  WorkflowTriggerListView.swift 0.00 % 0 116
  PermissionsScene.swift 100.00 % 29 29
  ConfigurationStore.swift 5.00 % 3 60
  WindowRunnerDecreaseWindowSize.swift 0.00 % 0 35
  DetailModelMapper.swift 0.00 % 0 201
  SidebarCoordinator.swift 0.00 % 0 160
  FocusView.swift 0.00 % 0 113
  WindowCommandRunner+Helpers.swift 0.00 % 0 32
  ScriptCommand.swift 13.33 % 6 45
  DetailCommandContainerActionReducer.swift 0.00 % 0 15
  SplashView.swift 0.00 % 0 204
  NewCommandValidation.swift 0.00 % 0 27
  SidebarAddGroupButtonView.swift 0.00 % 0 43
  GroupItemView.swift 0.00 % 0 109
  ContentScriptImageView.swift 0.00 % 0 60
  WorkflowNotificationView.swift 0.00 % 0 186
  MachPortUINotifications.swift 0.00 % 0 88
  WorkflowNotificationController.swift 0.00 % 0 26
  FileWatcher.swift 0.00 % 0 30
  CommandKeyIcon.swift 0.00 % 0 79
  DetailViewActionReducer.swift 0.00 % 0 176
  ContentViewActionReducer.swift 67.35 % 33 49
  MachPortCoordinator.swift 0.00 % 0 292
  URLIcon.swift 0.00 % 0 98
  OpenPanelController.swift 2.86 % 1 35
  WindowCommand.swift 0.00 % 0 175
  KeyCodesStore.swift 0.00 % 0 42
  ContentImagesView.swift 0.00 % 0 76
  DebugGenerator.swift 0.00 % 0 41
  DraggableView.swift 0.00 % 0 16
  DebounceManager.swift 0.00 % 0 11
  DropCommandsController.swift 98.04 % 50 51
  ShortcutCommand.swift 0.00 % 0 19
  KeyShortcut.swift 100.00 % 40 40
  ColorPalette.swift 0.00 % 0 73
  Command.swift 31.82 % 77 242
  WorkflowCommandListView.swift 0.00 % 0 46
  CommandSymbol.swift 0.00 % 0 134
  TuistBundle+KeyboardCowboy.swift 0.00 % 0 3
  WindowRunnerIncreaseWindowSize.swift 0.00 % 0 76
  NewCommandShortcutView.swift 0.00 % 0 131
  DebounceSelectionManager.swift 0.00 % 0 18
  FolderSymbol.swift 0.00 % 0 306
  NewCommandApplicationView.swift 0.00 % 0 344
  CloseApplicationPlugin.swift 0.00 % 0 19
  ContentIconImageView.swift 0.00 % 0 27
  FeatureIcon.swift 0.00 % 0 99
  Core.swift 20.25 % 16 79
  AddButtonView.swift 0.00 % 0 110
  KeyboardCommandRunner.swift 0.00 % 0 55
  ApplicationTrigger.swift 47.62 % 10 21
  WorkflowTriggerView.swift 0.00 % 0 157
  WifiInfo.swift 0.00 % 0 26
  NewCommandBuiltInView.swift 0.00 % 0 6
  TypingSymbol.swift 0.00 % 0 51
  LaunchApplicationPlugin.swift 0.00 % 0 16
  EditableKeyboardShortcutsView.swift 0.00 % 0 724
  MissionControlPlugin.swift 0.00 % 0 32
  SidebarConfigurationHeaderView.swift 0.00 % 0 7
  NewCommandImageView.swift 0.00 % 0 80
  ApplicationStore.swift 37.50 % 48 128
  GroupBackgroundView.swift 0.00 % 0 24
  DetailCommandActionReducer.swift 0.00 % 0 258
  WorkflowCommandListScrollView.swift 0.00 % 0 308
  EditConfigurationView.swift 0.00 % 0 118
  WorkflowOuputView.swift 0.00 % 0 98
  FocusPublisher.swift 0.00 % 0 27
  KeyboardCowboyConfiguration.swift 4.49 % 8 178
  AutoCompletionStore.swift 0.00 % 0 5
  PermissionsView.swift 0.64 % 2 313
  CommandRunner.swift 0.00 % 0 229
  TuistAssets+KeyboardCowboy.swift 0.00 % 0 40
  KeyboardCowboy+Extensions.swift 45.45 % 10 22
  BringToFrontApplicationPlugin.swift 0.00 % 0 16
  TypeCommandView.swift 0.00 % 0 116
  SidebarMapper.swift 0.00 % 0 25
  WorkflowApplicationTriggerView.swift 0.00 % 0 254
  CommandView.swift 0.00 % 0 307
  View+Extensions.swift 0.00 % 0 179
  ContentListFilterView.swift 0.00 % 0 96
  KeyShortcutRecorderStore.swift 0.00 % 0 10
  FocusableProxy.swift 0.00 % 0 57
  WorkflowShortcutsView.swift 0.00 % 0 48
  NewCommandButtonView.swift 0.00 % 0 18
  StorageConfiguration.swift 57.14 % 4 7
  DropItem.swift 0.00 % 0 18
  Rule.swift 0.00 % 0 13
  LoginItem.swift 13.64 % 3 22
  SystemInfo.swift 0.00 % 0 17
  AppDelegate.swift 81.82 % 9 11
  KeyboardShortcutTrigger.swift 100.00 % 11 11
  EditableKeyboardShortcutsItemView.swift 0.00 % 0 94
  Workflow.swift 33.56 % 49 146
  KeyboardCowboyEngine.swift 0.00 % 0 98
  AppStorageStore.swift 100.00 % 8 8
  Binding+Extensions.swift 0.00 % 0 8
  ContentShortcutImageView.swift 0.00 % 0 19
  DesignTime+Extensions.swift 0.00 % 0 11
  WindowListStore.swift 0.00 % 0 7
  CommandViewModel.swift 0.00 % 0 2
  WorkflowGroup.swift 18.75 % 12 64
  FeatureBetaModifier.swift 0.00 % 0 309
  ContentCoordinator.swift 0.00 % 0 159
  ApplicationTriggerController.swift 98.35 % 119 121
  KeyboardView.swift 0.00 % 0 780
  WorkflowCommandListHeaderView.swift 0.00 % 0 86
  WindowManagementAnimationPopoverView.swift 0.00 % 0 87
  NotificationWindow.swift 0.00 % 0 32
  GeometryPreferenceKeyView.swift 0.00 % 0 9
  ApplicationCommandRunner.swift 0.00 % 0 71
  ApplicationSettingsView.swift 0.96 % 3 314
  OpenURLParser.swift 0.00 % 0 16
  WindowManagementCommandView.swift 0.00 % 0 1683
  ApplicationCommand.swift 47.37 % 18 38
  DetailEmptyView.swift 0.00 % 0 7
  Array+Extensions.swift 0.00 % 0 28
  DetailViewModel.swift 0.00 % 0 34
  FolderIcon.swift 0.00 % 0 285
  GroupsView.swift 0.00 % 0 30
  BuildInCommand.swift 58.82 % 20 34
  KeyBackgroundView.swift 0.00 % 0 37
  NewSystemCommandView.swift 0.00 % 0 108
  MenubarIcon.swift 0.00 % 0 88
  SidebarNewConfigurationPopoverView.swift 0.00 % 0 60
  ShortcutStore.swift 7.84 % 4 51
  IconView.swift 0.00 % 0 86
  NewCommandKeyboardShortcutView.swift 0.00 % 0 102
  AppsIcon.swift 0.00 % 0 80
  SystemCommand.swift 0.00 % 0 36
  Set+Extensions.swift 0.00 % 0 16
  SelectionManager.swift 9.47 % 16 169
  NewCommandOpenView.swift 0.00 % 0 282
  ContentItemBadgeOverlayView.swift 0.00 % 0 25
  TypeCommandRunner.swift 0.00 % 0 36
  Application.swift 19.30 % 11 57
  EnterKey.swift 0.00 % 0 173
  AppEnvironment.swift 0.00 % 0 1
  ContentModelMapper.swift 0.00 % 0 195
  Draggable+Extensions.swift 0.00 % 0 12
  MultiDetailView.swift 0.00 % 0 414
  URLSymbol.swift 0.00 % 0 68
  AppCache.swift 36.96 % 17 46
  ScriptSymbol.swift 0.00 % 0 77
  DetailView.swift 0.00 % 0 40
  ActivateApplicationPlugin.swift

Details

Test Details

UnitTestsback

ApplicationTriggerControllerTests back

SuccessFailureSkippedExpected Failure⏱️
3 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testApplicationTriggerController_closed()
Successtest-method testApplicationTriggerController_frontMost()
Successtest-method testApplicationTriggerController_launched()

ApplicationTriggerTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testCopy()

CommandTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testCopy()

ContentViewActionReducerTests back

SuccessFailureSkippedExpected Failure⏱️
5 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testReduceContentViewAction_addWorkflow()
Successtest-method testReduceContentViewAction_moveWorkflows()
Successtest-method testReduceContentViewAction_moveWorkflowsToGroup()
Successtest-method testReduceContentViewAction_noop()
Successtest-method testReduceContentViewAction_removeWorflows()

DropCommandsControllerTests back

SuccessFailureSkippedExpected Failure⏱️
5 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testGeneratingAppleScriptCommand()
Successtest-method testGeneratingApplicationCommand()
Successtest-method testGeneratingFileCommand()
Successtest-method testGeneratingShellScriptCommand()
Successtest-method testGeneratingWebCommand()

KeyShortcutTests back

SuccessFailureSkippedExpected Failure⏱️
9 (100%)0 (0%)0 (0%)0 (0%)0.01s
Successtest-method testEmptyMethod()
Successtest-method testFromDecoder_ID_Key_Data()
Successtest-method testFromDecoder_ID_Key_LHS_Data()
Successtest-method testFromDecoder_ID_Key_LHS_Modifier_Data()
Successtest-method testFromDecoder_ID_Key_LHS_Modifiers_Data()
Successtest-method testFromDecoder_Key_Data()
Successtest-method testModifersDisplayValue()
Successtest-method testStringValue()
Successtest-method testValidationValue()

KeyboardShortcutTriggerTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testCopy()

KeyboardShortcutsControllerTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.09s
Successtest-method testLookupInLargeCollection()

WorkflowTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.00s
Successtest-method testCopy()
View more details on GitHub Actions