Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ledger extension #1110

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Add Ledger extension #1110

merged 1 commit into from
Jul 23, 2024

Conversation

mrkstwrt
Copy link
Contributor

No description provided.

Copy link

cla-bot bot commented Jul 21, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @mrkstwrt on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@mrkstwrt
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Jul 21, 2024
Copy link

cla-bot bot commented Jul 21, 2024

The cla-bot has been summoned, and re-checked this pull request!

@mrkstwrt
Copy link
Contributor Author

@maxdeviant sorry I've updated the submodule to use https instead

maxdeviant
maxdeviant previously approved these changes Jul 22, 2024
Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@maxdeviant maxdeviant self-requested a review July 22, 2024 15:09
@maxdeviant maxdeviant dismissed their stale review July 22, 2024 15:10

Was looking at a stale copy.

@mrkstwrt
Copy link
Contributor Author

@maxdeviant should be fixed now, updated the id in my extension to match the extensions.toml id

@maxdeviant maxdeviant merged commit b7d0b46 into zed-industries:main Jul 23, 2024
2 checks passed
adorabilis pushed a commit to adorabilis/zed-extensions that referenced this pull request Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants