Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream logs in Loki #1

Open
AxiomSamarth opened this issue Oct 8, 2022 · 1 comment
Open

Stream logs in Loki #1

AxiomSamarth opened this issue Oct 8, 2022 · 1 comment

Comments

@AxiomSamarth
Copy link

The current implementation loads the pod logs into Loki until the timestamp when we run lomba run. It will be great if we can stream pod logs in Loki.

@AxiomSamarth
Copy link
Author

I have a solution proposed the linked PR where streaming is implemented.

As goroutines are employed to stream the pod logs, to keep them active, we need to ensure that the main doesn't terminate. Hence, a new flag stream-duration is newly introduced. This will keep main active and the streaming will continue for a duration as set by stream-duration. Default value of stream-duration is set to 1 hour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant