Let Xarray handle decode_times
#232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norlandrhagen
temporarily deployed
to
test-release
GitHub Actions
Inactive
TomNicholas
reviewed
Aug 27, 2024
norlandrhagen
temporarily deployed
to
test-release
GitHub Actions
Inactive
norlandrhagen
temporarily deployed
to
test-release
GitHub Actions
Inactive
norlandrhagen
temporarily deployed
to
test-release
GitHub Actions
Inactive
|
@norlandrhagen I merged in the changes from |
TomNicholas
temporarily deployed
to
test-release
GitHub Actions
Inactive
…dated xr.open_dataset decode behavior
norlandrhagen
temporarily deployed
to
test-release
GitHub Actions
Inactive
|
Thanks for fixing that @norlandrhagen ! Let's just add a note to the release notes to explain to users what we have just changed, then this should be good to merge. Also FYI @jsignell |
norlandrhagen
temporarily deployed
to
test-release
GitHub Actions
Inactive
TomNicholas
reviewed
Aug 27, 2024
TomNicholas
temporarily deployed
to
test-release
GitHub Actions
Inactive
jsignell
reviewed
Sep 4, 2024
| @@ -54,6 +53,7 @@ def open_virtual_dataset( | |||
| filetype: FileType | None = None, | |||
| drop_variables: Iterable[str] | None = None, | |||
| loadable_variables: Iterable[str] | None = None, | |||
| decode_times: bool | None = None, | |||
| cftime_variables: Iterable[str] | None = None, | |||
There was a problem hiding this comment.
Just seeing this after getting back from break. Should the cftime_variables kwarg be removed?
EDIT: oohh I see it's being deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/releases.rst