-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal refactor to separate reading and writing concerns #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomNicholas
temporarily deployed
to
test-release
August 26, 2024 23:01
— with
GitHub Actions
Inactive
TomNicholas
temporarily deployed
to
test-release
August 26, 2024 23:07
— with
GitHub Actions
Inactive
TomNicholas
temporarily deployed
to
test-release
August 26, 2024 23:24
— with
GitHub Actions
Inactive
TomNicholas
temporarily deployed
to
test-release
August 27, 2024 01:31
— with
GitHub Actions
Inactive
TomNicholas
temporarily deployed
to
test-release
August 27, 2024 01:33
— with
GitHub Actions
Inactive
TomNicholas
changed the title
Internal refactor
Internal refactor to separate reading and writing concerns
Aug 27, 2024
TomNicholas
temporarily deployed
to
test-release
August 27, 2024 01:37
— with
GitHub Actions
Inactive
TomNicholas
temporarily deployed
to
test-release
August 27, 2024 02:02
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reorganizes basically the whole repo without actually changing any behaviour or public API. I've literally just copied and pasted code, created, renamed and moved files, and edited imports to match. The point is to split up various things that should be thought of separately:
xarray.py
is split intobackend.py
(which containsopen_virtual_dataset
for reading things) andaccessor.py
(which contains the.virtualize
accessor for serializing things). Sean's hdf5 reader will go in here too (see [Draft] Non-kerchunk backend for HDF5/netcdf4 files. #87).kerchunk.py
file has now got so little in it that it only contains type definitions (which really should be defined upstream...), so has been moved to a newvirtualizarr.types.kerchunk
module.These changes should make the structure of the codebase clearer, and especially the structure of the relationship to kerchunk code. i.e. it should now be clearer that kerchunk is one amongst many virtualizarr readers, and one amongst many virtualizarr writers, but not actually required for either.
Tests addeddocs/releases.rst
New functions/methods are listed inapi.rst
New functionality has documentation