Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the theme options for pydata_sphinx_theme #223

Merged
merged 5 commits into from
Aug 21, 2024

Conversation

keewis
Copy link
Contributor

@keewis keewis commented Aug 21, 2024

This is option 1 from #220 (comment): keep using pydata_sphinx_theme, but use the proper html theme options.

Edit: looks like the html_context options (github_user, github_repo, github_version, docs) are there to add a source edit link, which has to be enabled with use_edit_page_button.

For the link to github, we needed to add an icon link.

@TomNicholas TomNicholas added the documentation Improvements or additions to documentation label Aug 21, 2024
@TomNicholas
Copy link
Collaborator

Thanks @keewis ! This looks like it's working to me - ready to merge?

@keewis
Copy link
Contributor Author

keewis commented Aug 21, 2024

yep, go ahead

@TomNicholas TomNicholas merged commit 0343d48 into zarr-developers:main Aug 21, 2024
5 checks passed
@keewis keewis deleted the docs-links branch August 21, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No link to github from the docs
2 participants